Fixes gh-697 Enhance SqsAutoConfiguration to use an available ObjectM… #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ObjectMapper for SqsContainerOptions.
mmaeller
requested review from
maciejwalkowiak,
MatejNedic and
tomazfernandes
as code owners
tomazfernandes
requested changes
Sep 6, 2023
There was a problem hiding this comment.
Sorry for the delay @mmaeller! Looks good, but there's an issue with the formatting that's creating lots of diffs.
Can you please fix that?
Thanks!
| assertThat(options.getMessageConverter()).isInstanceOfSatisfying( | ||
| SqsMessagingMessageConverter.class, | ||
| messageConverter -> assertThat(messageConverter.getPayloadMessageConverter()) | ||
| .isInstanceOfSatisfying(CompositeMessageConverter.class, |
There was a problem hiding this comment.
This is a very long chain, perhaps if we use extracting instead of isInstanceOfSatisfying we could make it simpler?
| assertThat(options.getMaxConcurrentMessages()).isEqualTo(10); | ||
| assertThat(options.getMaxMessagesPerPoll()).isEqualTo(10); | ||
| assertThat(options.getPollTimeout()).isEqualTo(Duration.ofSeconds(10)); | ||
| assertThat(options.getMessageConverter()).isInstanceOfSatisfying( |
There was a problem hiding this comment.
Same here, please let's try to simplify this a bit.
9 tasks
|
@tomazfernandes I made the requested changes in a new PR: #906 - I really would like this released and it seems the original author hasn't had time. :-) |
|
Hi @postalservice14, Thank you for the adjustments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
See #697 (reply in thread)
💡 Motivation and Context
Please see #697
💚 How did you test it?
See extended unit tests.
📝 Checklist
🔮 Next steps